Skip to content

fix: add version label to environment cards#2379

Merged
kmendell merged 1 commit intomainfrom
fix/version-label-on-card
Apr 17, 2026
Merged

fix: add version label to environment cards#2379
kmendell merged 1 commit intomainfrom
fix/version-label-on-card

Conversation

@kmendell
Copy link
Copy Markdown
Member

@kmendell kmendell commented Apr 16, 2026 •
edited by greptile-apps bot
Loading

Checklist

  • This PR is not opened from my fork’s main branch

What This PR Implements

Fixes:

Changes Made

Testing Done

  • Development environment started: ./scripts/development/dev.sh start
  • Frontend verified at http://localhost:3000
  • Backend verified at http://localhost:3552
  • Manual testing completed (describe):
  • No linting errors (e.g., just lint all)
  • Backend tests pass: just test backend

AI Tool Used (if applicable)

AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:

Additional Context

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

This PR adds version labels to environment cards on the all-environments dashboard view. The backend is extended to fetch version info alongside the snapshot in a parallel errgroup fan-out, and the frontend replaces per-card individual loadPromise instances with a single centralized environmentBoardStatePromise that resolves all environments at once.

The backend changes are clean — the errgroup pattern is correctly applied, nil-service guards prevent panics in test scenarios, and test coverage addresses the happy path, offline environments, and remote version-fetch failures.

Confidence Score: 5/5

Safe to merge; only a P2 style finding from this review pass.

All new findings from this review are P2 (style/suggestion level). The backend logic is well-structured and tested. Prior-thread concerns are tracked separately and do not block merge.

frontend/src/routes/(app)/dashboard/+page.svelte — debugUpgrade state has no activation path

Fix All in Codex

Prompt To Fix All With AI 
This is a comment left during a code review.
Path: frontend/src/routes/(app)/dashboard/+page.svelte
Line: 75

Comment:
**`debugUpgrade` has no activation path**

`debugUpgrade` is declared as a static `$state(false)` with no way to set it to `true` at runtime. Unlike `debugAllGood` — which is derived from page data (`data.debugAllGood ?? false`) and can be toggled via a URL param or the server `load` function — `debugUpgrade` is always `false`. This makes the entire debug-upgrade path in `DashboardAllEnvironmentsView` (the fake version badge, the `debug` prop on `DashboardEnvironmentUpgradeAction`) permanently unreachable in production and during normal development without Svelte DevTools.

Consider deriving it from page data the same way `debugAllGood` is:

```suggestion
	let debugUpgrade = $derived(data.debugUpgrade ?? false);
```

How can I resolve this? If you propose a fix, please make it concise.

Reviews (3): Last reviewed commit: "fix: add version label to environment ca..." | Re-trigger Greptile

@kmendell kmendell marked this pull request as ready for review April 16, 2026 02:25
@kmendell kmendell requested a review from a team April 16, 2026 02:25
@kmendell
Copy link
Copy Markdown
Member Author

kmendell commented Apr 16, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@kmendell Graphite App
Copy link
Copy Markdown
Member Author

kmendell commented Apr 16, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@getarcaneappbot
Copy link
Copy Markdown
Contributor

getarcaneappbot commented Apr 16, 2026 •
edited
Loading

Container images for this PR have been built successfully!

  • Manager: ghcr.io/getarcaneapp/arcane:pr-2379
  • Agent: ghcr.io/getarcaneapp/arcane-headless:pr-2379

Built from commit d3bb98a

greptile-apps[bot]
greptile-apps bot reviewed Apr 16, 2026
View reviewed changes
Comment thread frontend/src/routes/(app)/dashboard/dashboard-all-environments-view.svelte
Comment thread frontend/src/routes/(app)/dashboard/dashboard-all-environments-view.svelte
Comment thread frontend/src/routes/(app)/dashboard/dashboard-all-environments-view.svelte
@kmendell kmendell force-pushed the fix/version-label-on-card branch from cddbba3 to 53ab5cb Compare April 16, 2026 02:47
@kmendell kmendell force-pushed the fix/version-label-on-card branch from 53ab5cb to d3bb98a Compare April 17, 2026 00:54
@kmendell kmendell merged commit e294d70 into main Apr 17, 2026
25 checks passed
@kmendell kmendell deleted the fix/version-label-on-card branch April 17, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

@kmendell kmendell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kmendell @getarcaneappbot